[3.8] bpo-10544: Disallow "yield" in comprehensions and generator expressions. by serhiy-storchaka · Pull Request #4564 · python/cpython
bpo-10544: Disallow "yield" in comprehensions and generator expressions.
[3.8] bpo-10544: Disallow "yield" in comprehensions and generator expressions.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a blocking review to ensure we don't merge this until after the 3.7 maintenance branch has been created.
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
Could you please look on this again Nick?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and the main branch is now open for 3.8 commits.
| @@ -0,0 +1,2 @@ | |||
| Yield expressions now are disallowed in comprehensions and generator | |||
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor wording tweak: now are -> are now
Maybe you can suggest better wording for What's New?
The What's New wording seemed fine to me.