◐ Shell
clean mode source ↗

bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. by serhiy-storchaka · Pull Request #4681 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Dec 2, 2017

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@serhiy-storchaka serhiy-storchaka added the type-bug

An unexpected behavior, bug, or error

label

Dec 2, 2017

@serhiy-storchaka serhiy-storchaka requested a review from a team as a code owner

December 2, 2017 18:50

@ned-deily ned-deily left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting for now LGTM. Thanks!

@serhiy-storchaka serhiy-storchaka merged commit 13badcb into python:master

Dec 2, 2017

@serhiy-storchaka serhiy-storchaka deleted the main-compile-error-osx branch

December 2, 2017 19:36

vstinner added a commit that referenced this pull request

Dec 4, 2017
…po-32030. (#4681)" (#4694)

* Revert "bpo-32197: Try to fix a compiler error on OS X introduced in bpo-32030. (#4681)"

This reverts commit 13badcb.

Re-apply commits:

* "bpo-32030: _PyPathConfig_Init() sets home and program_name (#4673)"
  commit af5a895.
* "bpo-32030: Fix config_get_program_name() on macOS (#4669)"
  commit e23c06e.
* "bpo-32030: Add Python/pathconfig.c (#4668)"
  commit 0ea395a.
* "bpo-32030: Don't call _PyPathConfig_Fini() in Py_FinalizeEx() (#4667)"
  commit ebac19d.
* "bpo-32030: Fix Py_GetPath(): init program_name (#4665)"
  commit 9ac3d88.

* Fix compilation error on macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees

No one assigned

Labels

skip news type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @ned-deily @CuriousLearner @the-knights-who-say-ni @bedevere-bot