◐ Shell
clean mode source ↗

bpo-27169: The __debug__ constant is now optimized out at compile time. by serhiy-storchaka · Pull Request #4880 · python/cpython

serhiy-storchaka

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Dec 15, 2017

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@methane methane left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit 3325a67 into python:master

Dec 15, 2017

@serhiy-storchaka serhiy-storchaka deleted the compile-__debug__ branch

December 15, 2017 10:35

@serhiy-storchaka serhiy-storchaka added type-bug

An unexpected behavior, bug, or error

needs backport to 3.6 and removed type-feature

A feature request or enhancement

labels

Dec 15, 2017

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

Copy link Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3325a6780c81f1ea51190370b5454879c4862a37 3.6

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Dec 15, 2017 
…le time. (pythonGH-4880)

This fixes also bpo-22091..
(cherry picked from commit 3325a67)

@bedevere-bot

Copy link Copy Markdown

GH-4882 is a backport of this pull request to the 3.6 branch.

serhiy-storchaka added a commit that referenced this pull request

Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Assignees

No one assigned

Labels

type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @methane @the-knights-who-say-ni