bpo-32411: IDLE: Remove line number sort in browser.py by csabella · Pull Request #5011 · python/cpython
Conversation
Since the input dictionary is created in line number and dictionaries are guaranteed to be in insertion order, the sort is no longer needed.
ON HOLD, as explained on the issue.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requested 'change' is to wait for circumstances to change ;-).
bpo-32411: IDLE: Remove sorting by line number in browser.py
bpo-32411: IDLE: Remove line number sort in browser.py
@terryjreedy: Please replace # with GH- in the commit message next time. Thanks!
Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
Insertion in line order makes sorting keys by line order unneeded. (cherry picked from commit 1a4d9ff) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request
Insertion in line order makes sorting keys by line order unneeded. (cherry picked from commit 1a4d9ff) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
DinoV pushed a commit to DinoV/cpython that referenced this pull request
Insertion in line order makes sorting keys by line order unneeded.