◐ Shell
clean mode source ↗

bpo-32593: Drop FreeBSD 9 and older support by vstinner · Pull Request #5232 · python/cpython

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see why FreeBSD has a special treatment it should work the same as linux here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, I don't know this code and I never understood what is rpath. If you consider that the code is outdated/can be simplified, would you mind to open a new issue? Maybe even write a PR to implement your proposed change?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is simple the only thing needed it dropping the block and let it fall into the else like linux

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #5233 : would you mind to review it and test it?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted this change and wrote PR #5233 instead.