◐ Shell
clean mode source ↗

bpo-29619: Convert st_ino using unsigned integer by vstinner · Pull Request #557 · python/cpython

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Py_BUILD_ASSERT.

Should test sizeof(st->st_ino) <= sizeof(unsigned long long).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, I wrote my assertion backwards... Fixed, thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sizeof(self->win32_file_index) <= sizeof(unsigned long long)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.