bpo-29768: Fixed compile-time check for expat version. by serhiy-storchaka · Pull Request #574 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
merged 1 commit into
Merged
Conversation
mention-bot
commented
Mar 9, 2017
mention-bot commented
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freddrake, @loewis, @akuchling, @tiran and @brettcannon to be potential reviewers.
gpshead
commented
Mar 9, 2017
gpshead commented
Member
The change looks fine. I do suggest double checking to confirm that XML_COMBINED_VERSION is defined in whatever the oldest version of expat we expect people to encounter is (something crazy old like RHEL/CentOS 5 era ish I'd assume).
serhiy-storchaka
commented
Mar 9, 2017
serhiy-storchaka commented
Member Author
XML_COMBINED_VERSION is defined at the top of this file.
22e707f
into
python:master
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request
(cherry picked from commit 22e707f)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request
(cherry picked from commit 22e707f)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request
(cherry picked from commit 22e707f)
serhiy-storchaka added a commit that referenced this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
