◐ Shell
clean mode source ↗

[3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-5726) by miss-islington · Pull Request #5747 · python/cpython

…nGH-21060)

(cherry picked from commit 08a6926)

Co-authored-by: Éric Araujo <merwok@netwok.org>

merwok

@Mariatta

The commit message was wrong: It should be include bpo-21060 and the original PR number GH-5726. Please update that too for the other backport PRs.

@merwok

Ok! I thought the new bpo-nnn style was recommended but the older shorter style #NNN still working.

@merwok merwok changed the title [3.6] Improve error message for "setup.py upload" without dist files (GH-21060) [3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-21060)

Feb 19, 2018

@Mariatta

That old style works in bpo but not in GitHub :)

@merwok

Yes I don’t expect github to create links to bpo but custom bots could do what they want.

I prefer bug tracker-neutral references like «#1234» that humans understand over site-specific «sf1234» or the ugly «issue1234». Also I used to try to keep the first line of commit logs short! But next time I’ll follow what works with the bots.

@Mariatta Mariatta changed the title [3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-21060) [3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-5726)

Feb 19, 2018

@miss-islington

@merwok: Backport status check is done, and it's a failure ❌ .

@Mariatta

PR title fixed. It needs to reference the PR on master, so bedevere can properly remove the label.

@miss-islington

@merwok: Backport status check is done, and it's a success ✅ .

@miss-islington