bpo-33041: Fix downcast warning on Windows by vstinner · Pull Request #6595 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Conversation
Cast pointer difference from ssize_t to int: a frame is very unlikely larger than 2 GB.
I'm not sure about silently downcasting ssize_t to int. Maybe a check at runtime would be safer, but I'm too lazy to write complex code to handle errors :-) What do you think @serhiy-storchaka? Is it ok to rely that a stack will not be larger than 2 GB?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is safe. This difference should be limited by co_stacksize which has type int.
I think it is safe. This difference should be limited by co_stacksize which has type int.
Oh right. Thanks for checking!
@vstinner: Please replace # with GH- in the commit message next time. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters