bpo-20104: Change the file_actions parameter of os.posix_spawn(). by serhiy-storchaka · Pull Request #6725 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
merged 2 commits into
Merged
Conversation
Member
- Make its default value an empty tuple instead of None.
- Make it a keyword-only parameter.
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting merge
label
serhiy-storchaka
requested review from
gpshead and
ned-deily
serhiy-storchaka
added
the
skip news
label
serhiy-storchaka
mentioned this pull request
serhiy-storchaka
requested a review
from pablogsal
serhiy-storchaka
mentioned this pull request
pablogsal
approved these changes
pablogsal
left a comment
pablogsal
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Do you want to wait until #6693 is merged to land this or you prefer to do it before?
Member Author
It doesn't matter what PR will be merged first. But I want to wait for a review from any of other involved core devs: @benjaminp or @gpshead.
serhiy-storchaka added 2 commits
* Make its default value an empty tuple instead of None. * Make it a keyword-only parameter.
serhiy-storchaka
force-pushed
the
posix_spawn-file_actions
branch
from
c55ac4f to
0b4798e
Compare
serhiy-storchaka
merged commit
d700f97
into
python:master
bedevere-bot
removed
the
awaiting merge
label
serhiy-storchaka
deleted the
posix_spawn-file_actions
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment