◐ Shell
clean mode source ↗

bpo-33505: Optimize asyncio.ensure_future by reordering if conditions by jimmylai · Pull Request #6836 · python/cpython

jimmylai

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@jimmylai

@jimmylai jimmylai commented

May 14, 2018

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

@jimmylai jimmylai requested review from 1st1 and asvetlov as code owners

May 14, 2018 22:07

@jimmylai jimmylai force-pushed the optimize-ensure-future branch 2 times, most recently from 90ec72a to 58bcbac Compare

May 15, 2018 13:51

@jimmylai jimmylai force-pushed the optimize-ensure-future branch from 58bcbac to 321f9b8 Compare

May 15, 2018 13:53

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @jimmylai for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@1st1

1st1 commented

May 28, 2018

Copy link Copy Markdown

Member

Thanks, Jimmy

@bedevere-bot

Copy link Copy Markdown

GH-7162 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 28, 2018 
…pythonGH-6836)

(cherry picked from commit e549c4b)

Co-authored-by: jimmylai <albert_chs@yahoo.com.tw>

@miss-islington

Copy link Copy Markdown

Contributor

Sorry, @jimmylai and @1st1, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e549c4be5fb010f5faf12236af8faa720a1429be 3.6

1st1 pushed a commit that referenced this pull request

May 28, 2018 
…GH-6836) (#7162)

(cherry picked from commit e549c4b)

Co-authored-by: jimmylai <albert_chs@yahoo.com.tw>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov

Assignees

@1st1 1st1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jimmylai @miss-islington @1st1 @bedevere-bot @the-knights-who-say-ni