[3.7] bpo-33509: Fix _warnings for module_globals=None (GH-6833) by miss-islington · Pull Request #6870 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Contributor
Don't crash on warnings.warn_explicit() if module_globals is not a dict.
(cherry picked from commit b056562)
Co-authored-by: Victor Stinner vstinner@redhat.com
Don't crash on warnings.warn_explicit() if module_globals is not a dict. (cherry picked from commit b056562) Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner
approved these changes
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
miss-islington
commented
May 15, 2018
miss-islington commented
Contributor Author
@vstinner: Backport status check is done, and it's a success ✅ .
820219f
into
python:3.7
miss-islington
commented
May 15, 2018
miss-islington commented
Contributor Author
Thanks!
vstinner
commented
May 16, 2018
vstinner commented
Member
"@miss-islington: Thanks!"
Oh. You're welcome. It was a pleasure to work with you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
