◐ Shell
clean mode source ↗

[3.7] bpo-33540: Add block_on_close attr to socketserver (GH-6911) by miss-islington · Pull Request #7088 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

May 24, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver to opt-in for pre-3.7 behaviour.
(cherry picked from commit 453bd0b)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33540

Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver to opt-in for pre-3.7 behaviour.
(cherry picked from commit 453bd0b)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit fa286ed into python:3.7

May 24, 2018

@miss-islington

Copy link Copy Markdown

Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-453bd0b-3.7 branch

May 24, 2018 01:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot