[3.7] bpo-33540: Add block_on_close attr to socketserver (GH-6911) by miss-islington · Pull Request #7088 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
Merged
Merged
Conversation
Contributor
Add a new block_on_close class attribute to ForkingMixIn and
ThreadingMixIn classes of socketserver to opt-in for pre-3.7 behaviour.
(cherry picked from commit 453bd0b)
Co-authored-by: Victor Stinner vstinner@redhat.com
Add a new block_on_close class attribute to ForkingMixIn and ThreadingMixIn classes of socketserver to opt-in for pre-3.7 behaviour. (cherry picked from commit 453bd0b) Co-authored-by: Victor Stinner <vstinner@redhat.com>
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
vstinner
approved these changes
vstinner
left a comment
vstinner
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good bot.
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
miss-islington
commented
May 24, 2018
miss-islington commented
Contributor Author
@vstinner: Backport status check is done, and it's a success ✅ .
miss-islington
merged commit
fa286ed
into
python:3.7
miss-islington
commented
May 24, 2018
miss-islington commented
Contributor Author
Thanks!
bedevere-bot
removed
the
awaiting merge
label
miss-islington
deleted the
backport-453bd0b-3.7
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment