Tweak .codedoc.yml to make it more useful by berkerpeksag · Pull Request #71 · python/cpython
| default: | ||
| threshold: 0.01 | ||
| only_pulls: true | ||
| paths: |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/* changes, but shouldn't it also run on directories like Objects/?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this means it only ends up being run for those directories, right?
Correct.
[...] but shouldn't it also run on directories like Objects/?
Good point. I'm reading docs again so I hopefully will have an answer :)
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems ok from what I understand of the docs (particularly the coverage/status/{changes|project} part), but I'd prefer to leave it to another set of eyes to approve.
| - "Mac/**/*" | ||
| - "PC/**/*" | ||
| - "PCbuild/**/*" | ||
| - "Tools/**/*" |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should add the Grammar directory.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, done.
Then I say merge it and let python-dev (or -committers; wherever @Haypo emailed) know about the requisite change.
lysnikolaou referenced this pull request in lysnikolaou/cpython
Test pasting with/without paste mode
This was referenced
