◐ Shell
clean mode source ↗

bpo-33469: RuntimeError after closing loop that used run_in_executor by 1st1 · Pull Request #7171 · python/cpython

1st1

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@1st1

@1st1 1st1 commented

May 28, 2018

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

@asvetlov asvetlov left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the patch!

@1st1 1st1 merged commit fdccfe0 into python:master

May 28, 2018

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@1st1 1st1 deleted the fixtp branch

May 28, 2018 21:10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 28, 2018 
…ythonGH-7171)

(cherry picked from commit fdccfe0)

Co-authored-by: Yury Selivanov <yury@magic.io>

@bedevere-bot

Copy link Copy Markdown

GH-7178 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 28, 2018 
…ythonGH-7171)

(cherry picked from commit fdccfe0)

Co-authored-by: Yury Selivanov <yury@magic.io>

@bedevere-bot

Copy link Copy Markdown

GH-7179 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request

May 28, 2018 
…H-7171)

(cherry picked from commit fdccfe0)

Co-authored-by: Yury Selivanov <yury@magic.io>

miss-islington added a commit that referenced this pull request

May 29, 2018 
…H-7171)

(cherry picked from commit fdccfe0)

Co-authored-by: Yury Selivanov <yury@magic.io>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@1st1 @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni