bpo-31368: Enhance os.preadv() documentation by pablogsal · Pull Request #7254 · python/cpython
| resources. | ||
|
|
||
| Currently, on Linux, this feature is usable only on a file descriptor opened | ||
| using the O_DIRECT flag. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O_DIRECT should be written :data:O_DIRECT to get a link to its doc.
| leaving the file offset unchanged. *buffers* must be a sequence of | ||
| :term:`bytes-like objects <bytes-like object>`. Buffers are processed in | ||
| array order. Entire contents of the first buffer is written before | ||
| proceeding to the second, and so on. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, a sentence like "The flags argument contains a bitwise OR of zero or more of the following flags:" is missing here.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| resources. | ||
|
|
||
| Currently, on Linux, this feature is usable only on a file descriptor opened | ||
| using the :data:`O_DIRECT`flag. |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space between ` and flag, no?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, sorry about that! Done
Thanks @pablogsal for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖
Thanks @pablogsal. I merged your PR and will backport it to 3.7.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request
(cherry picked from commit 02e2a08) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request
(cherry picked from commit 02e2a08) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>