◐ Shell
clean mode source ↗

[3.6] bpo-31234: Add test.support.wait_threads_exit() (GH-3578) by vstinner · Pull Request #7315 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 2 commits into

python:3.6from

vstinner:wait_threads_exit36

Jun 1, 2018

Merged

[3.6] bpo-31234: Add test.support.wait_threads_exit() (GH-3578)#7315

vstinner

merged 2 commits into

python:3.6from

vstinner:wait_threads_exit36

Conversation

@vstinner

@vstinner vstinner commented

Jun 1, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

vstinner added 2 commits

June 1, 2018 14:12
Use _thread.count() to wait until threads exit. The new context
manager prevents the "dangling thread" warning.

(cherry picked from commit ff40ecd)
Try to fix the "Warning -- threading_cleanup() failed to cleanup 1
threads" warning in test.lock_tests: wait a little bit longer to give
time to the threads to complete.

Warning seen on test_thread and test_importlib.

(cherry picked from commit 096ae33)

@vstinner vstinner merged commit 5dbb48a into python:3.6

Jun 1, 2018

@vstinner vstinner deleted the wait_threads_exit36 branch

June 1, 2018 13:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot