◐ Shell
clean mode source ↗

[3.6] bpo-33540, socketserver: Add _block_on_close for tests by vstinner · Pull Request #7317 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

vstinner

merged 1 commit into

python:3.6from

vstinner:block_on_close36

Jun 1, 2018

Merged

[3.6] bpo-33540, socketserver: Add _block_on_close for tests#7317

vstinner

merged 1 commit into

python:3.6from

vstinner:block_on_close36

Conversation

@vstinner

@vstinner vstinner commented

Jun 1, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

  • Add a private _block_on_close attribute to ForkingMixIn and
    ThreadingMixIn classes of socketserver.
  • Use _block_on_close=True in test_socketserver and test_logging

https://bugs.python.org/issue33540

* Add a private _block_on_close attribute to ForkingMixIn and
  ThreadingMixIn classes of socketserver.
* Use _block_on_close=True in test_socketserver and test_logging

@vstinner vstinner merged commit 1381bfe into python:3.6

Jun 1, 2018

@vstinner vstinner deleted the block_on_close36 branch

June 1, 2018 14:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @the-knights-who-say-ni @bedevere-bot