◐ Shell
clean mode source ↗

[3.7] bpo-33509: Fix test_warnings for python3 -Werror (GH-7365) by miss-islington · Pull Request #7384 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Jun 4, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
(cherry picked from commit e292b75)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue33509

Fix test_warnings.test_module_globals() when python3 is run with
-Werror.
(cherry picked from commit e292b75)

Co-authored-by: Victor Stinner <vstinner@redhat.com>

@vstinner vstinner left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner and @ned-deily: Backport status check is done, and it's a success ✅ .

2 similar comments

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner and @ned-deily: Backport status check is done, and it's a success ✅ .

@miss-islington

Copy link Copy Markdown

Contributor Author

@vstinner and @ned-deily: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit d2c6ecc into python:3.7

Jun 4, 2018

@miss-islington

Copy link Copy Markdown

Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-e292b75-3.7 branch

June 4, 2018 17:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot