◐ Shell
clean mode source ↗

bpo-33720: Reduces maximum marshal recursion depth on release builds. by zooba · Pull Request #7401 · python/cpython

zooba

Conversation

vstinner

if os.name == 'nt' and hasattr(sys, 'gettotalrefcount'):
# BUG: https://bugs.python.org/issue33720
# Windows always limits the maximum depth on release and debug builds
#if os.name == 'nt' and hasattr(sys, 'gettotalrefcount'):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to mark it as a temporary fix, I suggest:

# Windows always limits the maximum depth on release and debug builds
if os.name == 'nt':

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I want it to be a temporary fix :) I want the compiler bug that's generating bad stack frames to be fixed. Hopefully I'll hear back from them today whether it's really a bug or not though - if there's a good reason for it then this can become a permanent change.

@miss-islington

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@zooba zooba deleted the bpo-33720 branch

June 4, 2018 20:25

@bedevere-bot

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jun 4, 2018 
…pythonGH-7401)

(cherry picked from commit 2a4a62b)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>

miss-islington added a commit that referenced this pull request

Jun 4, 2018 
…GH-7401)

(cherry picked from commit 2a4a62b)

Co-authored-by: Steve Dower <steve.dower@microsoft.com>

Labels