◐ Shell
clean mode source ↗

bpo-20552: Use specific asserts in bytes tests by serhiy-storchaka · Pull Request #790 · python/cpython

serhiy-storchaka

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

Copy link Copy Markdown

Member

No description provided.

@serhiy-storchaka serhiy-storchaka added type-feature

A feature request or enhancement

needs backport to 2.7 tests

Tests in the Lib/test dir

labels

Mar 23, 2017

@mention-bot

Copy link Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @ezio-melotti and @nnorwitz to be potential reviewers.

@terryjreedy terryjreedy left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test changes (leave that to bots) but checked logical equivalency.

@vstinner vstinner merged commit 604e74c into python:master

Mar 27, 2017

@serhiy-storchaka serhiy-storchaka deleted the test-bytes-asserts branch

March 27, 2017 17:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

tests

Tests in the Lib/test dir

type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-storchaka @mention-bot @zhangyangyu @terryjreedy @brettcannon @vstinner @Mariatta @the-knights-who-say-ni