◐ Shell
clean mode source ↗

bpo-33418: Add tp_clear for function object by methane · Pull Request #8058 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@methane

@methane methane commented

Jul 3, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Without tp_clear, GC can't break cyclic reference.
It will cause memory leak when cyclic reference is
created intentionally.

https://bugs.python.org/issue33418

Without tp_clear, GC can't break cyclic reference.
It will cause memory leak when cyclic reference is
created intentionally.

@serhiy-storchaka

Copy link Copy Markdown

Member

I have doubts about backporting this change. This can expose bugs when a ref cycle be broken at unexpected place.

@methane methane merged commit 3c45240 into python:master

Jul 4, 2018

@methane methane deleted the func_clear branch

February 28, 2019 12:04

Yhg1s pushed a commit that referenced this pull request

Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot