◐ Shell
clean mode source ↗

bpo-33720: Refactor marshalling/unmarshalling floats. by serhiy-storchaka · Pull Request #8071 · python/cpython

serhiy-storchaka

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented

Jul 3, 2018

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

This may reduce the stack consumption for unmarshalling deeply
nested structures.

https://bugs.python.org/issue33720

 
This may reduce the stack consumption for unmarshalling deeply
nested structures.

@serhiy-storchaka serhiy-storchaka force-pushed the marshal-floats-refactoring branch from 979d682 to 282cf4f Compare

July 4, 2018 05:29

@serhiy-storchaka

Copy link Copy Markdown

Member Author

Unfortunately the goal is not achieved. This change doesn't reduce stack consumption in the PGO build on Windows (which is around 1600 bytes per level, much more than 256 bytes for the buffer). I'm merging this PR in master only just as refactoring.

@serhiy-storchaka serhiy-storchaka merged commit c573499 into python:master

Jul 24, 2018

@serhiy-storchaka serhiy-storchaka deleted the marshal-floats-refactoring branch

July 24, 2018 07:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

skip news type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @methane @zooba @the-knights-who-say-ni @bedevere-bot