◐ Shell
clean mode source ↗

[3.6] bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091) by miss-islington · Pull Request #8224 · python/cpython

the-knights-who-say-ni

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Jul 10, 2018

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Contributed by Bradley Laney.
(cherry picked from commit 6b490b5)

Co-authored-by: Bradley Laney bradley.laney@gmail.com

https://bugs.python.org/issue34031

 
Contributed by Bradley Laney.
(cherry picked from commit 6b490b5)

Co-authored-by: Bradley Laney <bradley.laney@gmail.com>

@taleinat taleinat left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

Copy link Copy Markdown

Contributor Author

@stoksc and @taleinat: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit cb14eb7 into python:3.6

Jul 10, 2018

@miss-islington miss-islington deleted the backport-6b490b5-3.6 branch

July 10, 2018 10:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @taleinat @the-knights-who-say-ni @bedevere-bot @stoksc