[3.7] bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests (GH-7683) by miss-islington · Pull Request #8675 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
Contributor
- make CallTip and ToolTip sub-classes of a common abstract base class
- remove ListboxToolTip (unused and ugly)
- greatly increase test coverage
- tested on Windows, Linux and macOS
(cherry picked from commit 87e59ac)
Co-authored-by: Tal Einat taleinat+github@gmail.com
…sts (pythonGH-7683) * make CallTip and ToolTip sub-classes of a common abstract base class * remove ListboxToolTip (unused and ugly) * greatly increase test coverage * tested on Windows, Linux and macOS (cherry picked from commit 87e59ac) Co-authored-by: Tal Einat <taleinat+github@gmail.com>
miss-islington
requested a review
from terryjreedy
as a code owner
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
mentioned this pull request
bedevere-bot
added
the
awaiting review
label
miss-islington
commented
Aug 5, 2018
miss-islington commented
Contributor Author
@taleinat: Backport status check is done, and it's a success ✅ .
taleinat
approved these changes
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
miss-islington
merged commit
e65ec49
into
python:3.7
bedevere-bot
removed
the
awaiting merge
label
miss-islington
deleted the
backport-87e59ac-3.7
branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment