◐ Shell
clean mode source ↗

[3.7] bpo-33839: refactor IDLE's tooltips & calltips, add docstrings and tests (GH-7683) by miss-islington · Pull Request #8675 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Aug 5, 2018

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

  • make CallTip and ToolTip sub-classes of a common abstract base class
  • remove ListboxToolTip (unused and ugly)
  • greatly increase test coverage
  • tested on Windows, Linux and macOS
    (cherry picked from commit 87e59ac)

Co-authored-by: Tal Einat taleinat+github@gmail.com

https://bugs.python.org/issue33839

…sts (pythonGH-7683)

* make CallTip and ToolTip sub-classes of a common abstract base class
* remove ListboxToolTip (unused and ugly)
* greatly increase test coverage
* tested on Windows, Linux and macOS
(cherry picked from commit 87e59ac)

Co-authored-by: Tal Einat <taleinat+github@gmail.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

@taleinat: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit e65ec49 into python:3.7

Aug 5, 2018

@miss-islington miss-islington deleted the backport-87e59ac-3.7 branch

August 5, 2018 06:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

No one assigned

Labels

type-feature

A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @taleinat @the-knights-who-say-ni @bedevere-bot