bpo-34373: fix test_mktime and test_pthread_getcpuclickid tests on AIX by aixtools · Pull Request #8726 · python/cpython
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I was wondering if this might be useful for other platforms as well (that cannot handle negative times) - so I put it in additional brackets. I'll use your recommendation and make it "AIX only".
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aixtools Mi comment only refers to a style issue (the braces should open on the same line and not in a new line:
if (year < 70) do { ... }
as opposed to
if (year < 70) do { ... }