bpo-8110: Refactor platform detection in subprocess by zware · Pull Request #9053 · python/cpython
Conversation
Check for functionality via imports rather than checking sys.platform specifically for Windows
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| try: | ||
| import msvcrt | ||
| import _winapi | ||
| _mswindows = True |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be in the "else" block?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _mswindows = True? sure, it could be. But it doesn't matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters