◐ Shell
clean mode source ↗

Doc: Disable smartquotes for zh-tw, fr and ja translations by adrianliaw · Pull Request #9423 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@adrianliaw

Copy link Copy Markdown

Contributor

This is a replacement for #9337 that uses smartquotes_excludes config in conf.py instead of docutils.conf. See the suggestion in https://mail.python.org/pipermail/doc-sig/2018-September/004084.html

See also: #4006

@JulienPalard Please test a build with this patch and validate if it fixes the smartquotes issue for French translations.

@JulienPalard

Copy link Copy Markdown

Member

Tested locally and it works for me. I'll try to get the docs azure builder use the right Sphinx version. We're already using sphinx > 1.7 in production so it's OK.

@JulienPalard

Copy link Copy Markdown

Member

@adrian Could you bump the sphinx version in .vsts/ and .travis.yml to please the CI?

This is a replacement for python#9337.

* Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf
* Disable smartquotes for Japanese, French and Traditional Chinese translations

See:
* Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html
* Original smartquotes issue in ja translations: https://bugs.python.org/issue31793
* Disabling for ja: python#4006
* Smartquotes issue in fr: python/python-docs-fr#303
* Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
….yml to 1.7

Disabling smartquotes in conf.py with Sphinx is available in Sphinx 1.7
thus updating the version requirements for building docs on CI.

@adrianliaw

Copy link Copy Markdown

Contributor Author

@JulienPalard JulienPalard merged commit c03bf0a into python:master

Nov 4, 2018

JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request

Nov 5, 2018

miss-islington pushed a commit that referenced this pull request

Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adrianliaw @JulienPalard @the-knights-who-say-ni @bedevere-bot