Doc: Disable smartquotes for zh-tw, fr and ja translations by adrianliaw · Pull Request #9423 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
adrianliaw
commented
Sep 19, 2018
adrianliaw
commented
Contributor
This is a replacement for #9337 that uses smartquotes_excludes config in conf.py instead of docutils.conf. See the suggestion in https://mail.python.org/pipermail/doc-sig/2018-September/004084.html
See also: #4006
@JulienPalard Please test a build with this patch and validate if it fixes the smartquotes issue for French translations.
the-knights-who-say-ni
added
the
CLA signed
label
bedevere-bot
added
the
awaiting review
label
JulienPalard
added
skip issue
skip news
labels
JulienPalard
commented
Oct 10, 2018
JulienPalard commented
Member
Tested locally and it works for me. I'll try to get the docs azure builder use the right Sphinx version. We're already using sphinx > 1.7 in production so it's OK.
JulienPalard
commented
Oct 10, 2018
JulienPalard commented
Member
@adrian Could you bump the sphinx version in .vsts/ and .travis.yml to please the CI?
JulienPalard
mentioned this pull request
adrianliaw added 3 commits
This is a replacement for python#9337. * Using conf.py to disable smartquotes through Sphinx instead of using docutils.conf * Disable smartquotes for Japanese, French and Traditional Chinese translations See: * Suggesting to use conf.py: https://mail.python.org/pipermail/doc-sig/2018-September/004084.html * Original smartquotes issue in ja translations: https://bugs.python.org/issue31793 * Disabling for ja: python#4006 * Smartquotes issue in fr: python/python-docs-fr#303 * Smartquotes issue in zh_TW: https://mail.python.org/pipermail/doc-sig/2018-August/004079.html
Using smartquotes_excludes option in conf.py requires Sphinx 1.6.6 or more. See: http://www.sphinx-doc.org/en/1.7/config.html#confval-smartquotes_excludes
….yml to 1.7 Disabling smartquotes in conf.py with Sphinx is available in Sphinx 1.7 thus updating the version requirements for building docs on CI.
adrianliaw
force-pushed
the
disable-smartquotes
branch
from
675534a to
be13af3
Compare
adrianliaw
commented
Oct 11, 2018
adrianliaw commented
Contributor Author
@JulienPalard Done!
JulienPalard added 3 commits
JulienPalard
merged commit
c03bf0a
into
python:master
bedevere-bot
removed
the
awaiting review
label
JulienPalard pushed a commit to JulienPalard/cpython that referenced this pull request
…thonGH-9423) (cherry picked from commit c03bf0a)
AA-Turner
mentioned this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment