◐ Shell
clean mode source ↗

[3.11] GH-93516: Backport GH-93769 by markshannon · Pull Request #94231 · python/cpython

Conversation

…ute it all the time when tracing.

@arhadthedev

@markshannon markshannon changed the title [3.11] GH-93516: Backport 93769 [3.11] GH-93516: Backport GH-93769

Jun 24, 2022

@markshannon

@pablogsal I'd like to get this merged, as it will be needed for the backport of #94371

pablogsal

pablogsal

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pablogsal

@pablogsal

I cannot push to the PR, but you can copy this commit into yours if you want:

pablogsal@8380dd0

@markshannon

@markshannon

I see, it is because of the assert changing the line numbers.
Why does an application binary interface include line numbers?

@pablogsal

Why does an application binary interface include line numbers?

Those are not taken into account when checking it. They just come from the DWARF if I am not mistaken

pablogsal

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !