◐ Shell
clean mode source ↗

[3.11] GH-93516: Drop broken assert, fixes GH-93769 by tiran · Pull Request #94411 · python/cpython

tiran

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@tiran

@tiran tiran commented

Jun 29, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

The assert is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be _PyOpcode_Deopt[_Py_OPCODE(...)] instead of
_PyOpcode_Deopt[...].
gpshead reacted with hooray emoji 
The ``assert`` is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be ``_PyOpcode_Deopt[_Py_OPCODE(...)]`` instead of
``_PyOpcode_Deopt[...]``.

@tiran tiran requested a review from markshannon as a code owner

June 29, 2022 10:46

@tiran tiran added skip news 🔨 test-with-buildbots

Test PR w/ buildbots; report in status section

labels

Jun 29, 2022

@bedevere-bot

Copy link Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 8fd8bc4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@markshannon

Copy link Copy Markdown

Member

Thanks

@markshannon markshannon merged commit 9140c41 into python:3.11

Jun 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiran @bedevere-bot @markshannon