◐ Shell
clean mode source ↗

bpo-34749: Improved performance of binascii.a2b_base64(). by sir-sigurd · Pull Request #9444 · python/cpython

@csabella

@encukou, there are now merge conflicts between this and GH-4108 (bpo-31862). Do you think the changes here would be compatible with the other changes being proposed for upcoming PEPs? Thanks!

@encukou

The conflicts look minor (though Git rightly thinks they're better left to humans). I don't know about all upcoming PEPs, but I'm not aware of conflicts.
Unfortunately I won't have time for review in the next few months :(

@csabella

@encukou, thank you for the response. This one may need to wait a little longer until a reviewer is available then.

encukou

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased on top of the module state changes in master.
I can still see the speedup, can't find any new bugs, and I haven't been able to speed it up more :)

@miss-islington

@sir-sigurd: Status check is done, and it's a success ✅ .

@sir-sigurd

lisroach pushed a commit to lisroach/cpython that referenced this pull request

Sep 10, 2019

DinoV pushed a commit to DinoV/cpython that referenced this pull request

Jan 14, 2020