◐ Shell
clean mode source ↗

gh-82504: deprecate the MultiLoopChildWatcher by graingert · Pull Request #94648 · python/cpython

bedevere-bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@graingert graingert changed the title bpo-82504: deprecate the MultiLoopChildWatcher gh-82504: deprecate the MultiLoopChildWatcher

Jul 7, 2022

@graingert graingert marked this pull request as ready for review

July 7, 2022 09:18

@graingert graingert requested review from 1st1 and asvetlov as code owners

July 7, 2022 09:18

@kumaraditya303 kumaraditya303 left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to add What's New entry about this deprecation.

 
…tYAz.rst

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

@graingert graingert force-pushed the deprecate-multi-loop-watcher branch from 84a0ca0 to 2e6e996 Compare

July 18, 2022 16:20

@kumaraditya303 kumaraditya303 left a comment •

edited

Loading

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graingert

Copy link Copy Markdown

Contributor Author

thanks for the review @kumaraditya303 !
kumaraditya303 reacted with thumbs up emoji

@kumaraditya303

Copy link Copy Markdown

Contributor

@gvanrossum Would you like to review this? This deprecates MultiLoopChildWatcher which has race conditions so it is not even tested on CI currently, skipped on CI as of #26542.

@gvanrossum

Copy link Copy Markdown

Member

I'm sorry, I don't feel comfortable reviewing this. Any core dev CC'ed on the issue would be more qualified than me.

@gvanrossum gvanrossum removed their request for review

July 18, 2022 23:12

@graingert

Copy link Copy Markdown

Contributor Author

@kumaraditya303 can you request @njsmith on this?

@kumaraditya303

kumaraditya303 commented

Oct 9, 2022

•

edited

Loading

Copy link Copy Markdown

Contributor

Superseded by #98089

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@njsmith njsmith Awaiting requested review from njsmith

@vstinner vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@graingert @kumaraditya303 @gvanrossum @AlexWaygood @bedevere-bot