◐ Shell
clean mode source ↗

gh-94801: Use custom flags to check for headers and libs by tiran · Pull Request #94802 · python/cpython

@tiran

I addressed most places. The code now correctly triggers Emscripten's embuilder to download and install ports.

@tiran tiran marked this pull request as ready for review

July 13, 2022 21:30

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @tiran for commit 7bb04f3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

erlend-aasland

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

1 similar comment

@bedevere-bot

🤖 New build scheduled with the buildbot fleet by @tiran for commit 1311551 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

erlend-aasland

@miss-islington

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-94801-cflags branch

July 15, 2022 12:48

@miss-islington

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 944ff8c57c9e8ff5a5bd18925070ddb1504490ab 3.11

tiran added a commit to tiran/cpython that referenced this pull request

Jul 15, 2022

@bedevere-bot

tiran added a commit that referenced this pull request

Jul 18, 2022
…4802) (GH-94881)

Co-authored-by: Christian Heimes <christian@python.org>

@tiran tiran mentioned this pull request

Jul 18, 2022