◐ Shell
clean mode source ↗

[3.11] gh-72889: Remove redundant mock.Mock()._is_coroutine = False workarounds (GH-94926) by miss-islington · Pull Request #94934 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@miss-islington

@miss-islington miss-islington commented

Jul 17, 2022

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

(cherry picked from commit 07aeb74)

Co-authored-by: Thomas Grainger tagrain@gmail.com

…rkarounds (pythonGH-94926)

(cherry picked from commit 07aeb74)

Co-authored-by: Thomas Grainger <tagrain@gmail.com>

@miss-islington

Copy link Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

@gvanrossum gvanrossum left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass this is fine to land.

@miss-islington

Copy link Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 8d0249e into python:3.11

Jul 17, 2022

@miss-islington miss-islington deleted the backport-07aeb74-3.11 branch

July 17, 2022 17:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miss-islington @gvanrossum @bedevere-bot @graingert