gh-90928: Statically Initialize the Keywords Tuple in Clinic-Generated Code by ericsnowcurrently · Pull Request #95860 · python/cpython

ericsnowcurrently

We only statically initialize for core code and builtin modules. Extension modules still create the tuple at runtime. We'll solve that part of interpreter isolation separately.

This change includes generated code. The significant changes are in:

Tools/clinic/clinic.py
Python/getargs.c
Include/cpython/modsupport.h
Makefile.pre.in (re-generate global strings after running clinic)
very minor tweaks to Modules/_codecsmodule.c and Python/Python-tokenize.c

All other changes are generated code (clinic, global strings).

Issue: Statically Initialize PyArg_Parser in clinic.py #90928

ericsnowcurrently requested review from a team, 1st1, Fidget-Spinner, JelleZijlstra, abalkin, asvetlov, berkerpeksag, erlend-aasland, ethanfurman, gvanrossum, pganssle, rhettinger and tiran as code owners

August 10, 2022 20:24

LGTM.

We only statically initialize for core code and builtin modules. Extension modules still create the tuple at runtime.

Yeah, its better to solve it for builtins now, extensions modules can be solved later on.
FTR, I tried solving both at once ¹ and it worked on Linux but does not work on Windows because it does not allows taking addresses of DLL loaded symbols.

Footnotes

https://github.com/kumaraditya303/cpython/pull/4 ↩

Yeah, its better to solve it for builtins now, extensions modules can be solved later on.
FTR, I tried solving both at once 2 and it worked on Linux but does not work on Windows because it does not allows taking addresses of DLL loaded symbols.

I'm glad you agree. 😄 Splitting it up this way made the most sense.

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 3b308c4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

CC. @colorfulappl, regarding your PR #32092. This PR touches some of the same parts of AC and getarg.c.