◐ Shell
clean mode source ↗

gh-94808: Coverage: __build_class__ inside a non-dict __builtins__ by mdboom · Pull Request #95932 · python/cpython

bedevere-bot

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@mdboom

@mdboom mdboom commented

Aug 12, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

Adds coverage for this case inside the LOAD_BUILD_CLASS opcode in

@bedevere-bot bedevere-bot added tests

Tests in the Lib/test dir

awaiting review labels

Aug 12, 2022

@mdboom mdboom added the needs backport to 3.11

only security fixes

label

Aug 12, 2022

@miss-islington

Copy link Copy Markdown

Contributor

Thanks @mdboom for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 15, 2022 
…thonGH-95932)

(cherry picked from commit 3adb4d8)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>

@bedevere-bot bedevere-bot removed the needs backport to 3.11

only security fixes

label

Aug 15, 2022

@bedevere-bot

Copy link Copy Markdown

GH-96004 is a backport of this pull request to the 3.11 branch.

pablogsal pushed a commit that referenced this pull request

Sep 8, 2022 
#96004)

(cherry picked from commit 3adb4d8)

Co-authored-by: Michael Droettboom <mdboom@gmail.com>

Co-authored-by: Michael Droettboom <mdboom@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdboom @miss-islington @bedevere-bot @brandtbucher