◐ Shell
clean mode source ↗

gh-97527: IDLE: protect macosx Tk() call when no GUI by terryjreedy · Pull Request #97530 · python/cpython

terryjreedy

Only call tkinter.tk and its follow-up code in _init_tk_type
when requires('gui') does not raise.  This function can be
called as an unintended side-effect of calling other idlelib
code as part of tests on macOS without a GUI enabled.

ned-deily

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 24, 2022 
…97530)

Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise.  This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 24, 2022 
…97530)

Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise.  This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request

Sep 24, 2022 
Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise.  This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request

Sep 24, 2022 
Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise.  This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

terryjreedy added a commit to terryjreedy/cpython that referenced this pull request

Oct 16, 2022 
python#97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.

terryjreedy added a commit that referenced this pull request

Oct 16, 2022 
#97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 16, 2022 
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 16, 2022 
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 16, 2022 
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request

Oct 16, 2022 
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

miss-islington added a commit that referenced this pull request

Oct 16, 2022 
GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

hroncok pushed a commit to fedora-python/cpython that referenced this pull request

Nov 14, 2022 
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>