bpo-33613: Fix test_semaphore_tracker signal tests when using -Werror by pablogsal · Pull Request #9778 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Conversation
| os.kill(pid, signal.SIGKILL) | ||
| os.waitpid(pid, 0) | ||
| with warnings.catch_warnings(record=True) as all_warn: | ||
| warnings.simplefilter("always") |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't the recorded warnings just ignored?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing warnings!
Thank you for the catch and the review :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters