◐ Shell
clean mode source ↗

gh-92886: [clinic.py] raise exception on invalid input instead of assertion by iritkatriel · Pull Request #98051 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@iritkatriel

@iritkatriel iritkatriel commented

Oct 7, 2022

edited by miss-islington

Loading

Copy link Copy Markdown

Member

Tests should pass with -O (assertions off).

Automerge-Triggered-By: GH:iritkatriel

@iritkatriel iritkatriel added skip news 3.12

only security fixes

labels

Oct 7, 2022

@iritkatriel iritkatriel changed the title hg-92886: [clinic.py] raise exception on invalid input instead of assertion gh-92886: [clinic.py] raise exception on invalid input instead of assertion

Oct 7, 2022

@miss-islington

Copy link Copy Markdown

Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit 34e6f35 into python:main

Oct 7, 2022

carljm added a commit to carljm/cpython that referenced this pull request

Oct 8, 2022
* main: (38 commits)
  pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058)
  pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060)
  pythongh-57179: Add note on symlinks for os.walk (python#94799)
  pythongh-94808: Fix regex on exotic platforms (python#98036)
  pythongh-90085: Remove vestigial -t and -c timeit options (python#94941)
  pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347)
  pythongh-61105: Add default param, note on using cookiejar subclass (python#95427)
  pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271)
  pythongh-96073: fix backticks in NEWS entry (pythonGH-98056)
  pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051)
  pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000)
  pythonGH-88968: Reject socket that is already used as a transport (python#98010)
  pythongh-96346: Use double caching for re._compile() (python#96347)
  pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699)
  pythongh-96265: Fix some formatting in faq/design.rst (python#96924)
  pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840)
  pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934)
  pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940)
  pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957)
  pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039)
  ...

mpage pushed a commit to mpage/cpython that referenced this pull request

Oct 11, 2022
…of assertion (pythonGH-98051)

Tests should pass with -O (assertions off).

Automerge-Triggered-By: GH:iritkatriel

@iritkatriel iritkatriel deleted the test_clinic branch

October 18, 2022 14:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@larryhastings larryhastings Awaiting requested review from larryhastings

Assignees

No one assigned

Labels

3.12

only security fixes

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel @miss-islington @JelleZijlstra @bedevere-bot