GH-94597: Deprecate child watcher getters and setters by kumaraditya303 · Pull Request #98215 · python/cpython
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 9020f36 🤖
If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
The buildbots failures are unrelated. See #98216
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super keen on indenting all that code, otherwise I am fine with this. However, could you also add some deprecation notes to the docs? What's new in 3.12 also ideally should be updated (isn't there already something about watchers there?)
However, could you also add some deprecation notes to the docs? What's new in 3.12 also ideally should be updated (isn't there already something about watchers there?)
I was planning to finish docs afterwards but I added it now.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge.
| await transp._wait() | ||
| raise | ||
| with warnings.catch_warnings(): | ||
| warnings.simplefilter('ignore', DeprecationWarning) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't safe to disable warnings here, this is a process global and you're disabiling it for the whole wait
