gh-98254: Include stdlib module names in error messages for NameErrors by pablogsal · Pull Request #98255 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
Member
pablogsal
requested a review
from iritkatriel
as a code owner
bedevere-bot
added
the
awaiting core review
label
pablogsal added 4 commits
pablogsal
commented
Oct 13, 2022
pablogsal commented
Member Author
Suggestions for a better message (or combination of them) are welcomed!
pablogsal added 2 commits
pablogsal
requested a review
from terryjreedy
as a code owner
aroberge
mentioned this pull request
JelleZijlstra
approved these changes
JelleZijlstra
left a comment
JelleZijlstra
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, one tiny nit
Python/suggestions.c Outdated
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
pablogsal
merged commit
bb56dea
into
python:main
pablogsal
deleted the
gh-98254
branch
bedevere-bot
removed
the
awaiting merge
label
carljm added a commit to carljm/cpython that referenced this pull request
* main: (31 commits) pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345) pythongh-95914: Add What's New item describing PEP 670 changes (python#98315) Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358) pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316) pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333) pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001) pythongh-97669: Create Tools/build/ directory (python#97963) pythongh-95534: Improve gzip reading speed by 10% (python#97664) pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344) pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336) pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929) pythongh-85525: Remove extra row in doc (python#98337) pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457) pythongh-97527: IDLE - fix buggy macosx patch (python#98313) pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319) pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158) pythonGH-94597: Deprecate child watcher getters and setters (python#98215) pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255) Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294) [doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment