gh-98461: Fix source location in comprehensions bytecode by iritkatriel · Pull Request #98464 · python/cpython
Merged
Conversation
Member
iritkatriel
added
type-bug
labels
iritkatriel
requested a review
from brandtbucher
iritkatriel
self-assigned this
iritkatriel
requested a review
from markshannon
as a code owner
bedevere-bot
added
the
awaiting core review
label
blurb-it Bot and others added 3 commits
markshannon
approved these changes
markshannon
left a comment
•
edited
Loading
markshannon
left a comment
•
edited
edited
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
OOI, do all the new tests fail on main?
bedevere-bot
added
awaiting merge
and removed
awaiting core review
labels
iritkatriel
commented
Oct 20, 2022
iritkatriel commented
Member Author
OOI, do all the new tests fail on main?
They do, the location is wrong for the SET_ADD/LIST_APPEND etc.
iritkatriel
merged commit
4ec9ed8
into
python:main
bedevere-bot
removed
the
awaiting merge
label
carljm added a commit to carljm/cpython that referenced this pull request
* main: (40 commits) pythongh-98461: Fix source location in comprehensions bytecode (pythonGH-98464) pythongh-98421: Clean Up PyObject_Print (pythonGH-98422) pythongh-98360: multiprocessing now spawns children on Windows with correct argv[0] in virtual environments (pythonGH-98462) CODEOWNERS: Become a typing code owner (python#98480) [doc] Improve logging cookbook example. (pythonGH-98481) Add more tkinter.Canvas tests (pythonGH-98475) pythongh-95023: Added os.setns and os.unshare functions (python#95046) pythonGH-98363: Presize the list for batched() (pythonGH-98419) pythongh-98374: Suppress ImportError for invalid query for help() command. (pythongh-98450) typing tests: `_overload_dummy` raises `NotImplementedError`, not `RuntimeError` (python#98351) pythongh-98354: Add unicode check for 'name' attribute in _imp_create_builtin (pythonGH-98412) pythongh-98257: Make _PyEval_SetTrace() reentrant (python#98258) pythongh-98414: py.exe launcher does not use defaults for -V:company/ option (pythonGH-98460) pythongh-98417: Store int_max_str_digits on the Interpreter State (pythonGH-98418) Doc: Remove title text from internal links (python#98409) [doc] Refresh the venv introduction documentation, and correct the statement about VIRTUAL_ENV (pythonGH-98350) Docs: Bump sphinx-lint and fix unbalanced inline literal markup (python#98441) pythongh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) (pythonGH-93231) pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `_test_multiprocessing.py` (pythonGH-93233) pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_py_compile.py` (pythonGH-93235) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment