◐ Shell
clean mode source ↗

[3.11] gh-98548: Fix `-ne` shell operator spelling by sterliakov · Pull Request #98556 · python/cpython

sterliakov

Merged

ambv

merged 2 commits into

Oct 28, 2022

Conversation

@sterliakov

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

This follows #98555 for another affected branch.

@bedevere-bot

hauntsaninja

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sterliakov

Since the command expected to fail is short enough, maybe just

if ! make check-abidump; then
    echo ...
fi

is sufficient? The if and until conditions are not considered failing for -e. Yes, gihub actions use set -e (or bash -e, not sure about this) to fail on first failing step.

hauntsaninja

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. Want to update the 3.10 backport #98555 as well? :-) cc @JelleZijlstra

@sterliakov

encukou pushed a commit to encukou/cpython that referenced this pull request

May 23, 2023

Yhg1s pushed a commit that referenced this pull request

May 23, 2023 
Backport the workflow change and fix-ups:
- GH-92442 (e89c01e)
- GH-94129 (0dadb22)
- GH-98556 (194588d)

Co-Authored-By: sterliakov <50529348+sterliakov@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Labels