◐ Shell
clean mode source ↗

gh-90716: Fix pylong_int_from_string() refleak by vstinner · Pull Request #99094 · python/cpython

vstinner

Conversation

@vstinner

@vstinner vstinner commented

Nov 4, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

Fix validated by:

$ ./python -m test -R 3:3 test_int
Tests result: SUCCESS

Fix validated by:

    $ ./python -m test -R 3:3 test_int
    Tests result: SUCCESS

@vstinner

vstinner commented

Nov 4, 2022

Copy link Copy Markdown

Member Author

@kumaraditya303 kumaraditya303 left a comment

Copy link Copy Markdown

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 387f725 into python:main

Nov 4, 2022

@vstinner vstinner deleted the int_str branch

November 4, 2022 13:24

@gpshead

gpshead commented

Nov 4, 2022

Copy link Copy Markdown

Member

Heh, thanks!

@vstinner

vstinner commented

Nov 4, 2022

Copy link Copy Markdown

Member Author

I wrote an article on this fix :-) https://vstinner.github.io/debug-python-refleak.html

Heh, thanks!

From what I understood, the refleak existed before 4c4b5ce. It's just that thanks to the added test, the Refleaks buildbot spotted the leak.
gpshead and JulienPalard reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @gpshead @kumaraditya303 @bedevere-bot