◐ Shell
clean mode source ↗

GH-98831: Auto-generate PREDICTED() macro calls by gvanrossum · Pull Request #99102 · python/cpython

gvanrossum

Conversation

@gvanrossum

@gvanrossum gvanrossum commented

Nov 4, 2022

•

edited by bedevere-bot

Loading

Copy link Copy Markdown

Member

This allows us to remove all PREDICTED() calls from bytecodes.c. The generated_cases.c.h file is unchanged.

 
This allows us to remove all PREDICTED() calls from bytecodes.c.
The generated_cases.c.h file is unchanged.

@brandtbucher brandtbucher left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

This is exactly the sort of clean improvement I was hoping we could get out of this project... excited for more.
Comment thread

Tools/cases_generator/generate_cases.py Outdated 

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

@gvanrossum gvanrossum merged commit c885623 into python:main

Nov 4, 2022

@gvanrossum gvanrossum deleted the rm-predicted branch

November 4, 2022 22:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gvanrossum @brandtbucher @bedevere-bot