◐ Shell
clean mode source ↗

gh-87092: expose the compiler's codegen to python for unit tests by iritkatriel · Pull Request #99111 · python/cpython

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this (or the other functions) need to be an API function?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can _testinternalcapi import them otherwise?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, that why it has "internal" in the name.
It defines Py_BUILD_CORE_BUILTIN

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to work:

[ERROR] _testinternalcapi failed to import: dlopen(/Users/iritkatriel/src/cpython-654/build/lib.macosx-13.0-x86_64-3.12-pydebug/_testinternalcapi.cpython-312d-darwin.so, 0x0002): symbol not found in flat namespace '__PyCompile_CodeGen'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this PR now, it's getting into merge conflicts all the time. We can remove these from the API later if it's possible.