GH-94597: add deprecation warnings for subclassing `AbstractChildWatcher` by kumaraditya303 · Pull Request #99386 · python/cpython
-
-
Notifications
You must be signed in to change notification settings - Fork 34.7k
Merged
Conversation
Contributor
Contributor Author
This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason.
gvanrossum
approved these changes
gvanrossum
left a comment
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Do double check the appearance of the deprecation note.)
aa87432
into
python:main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
