gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac by thesamesam · Pull Request #99406 · python/cpython

bedevere-bot

Conversation

cc @erlend-aasland @kumaraditya303, followup from #99085.

Apologies for missing a few!

As penance, I'm going to do a followup now (but not generate configure yet as it won't be suitable to merge unless/until this is) in another PR for some AC_LANG_SOURCE porting (not doing it here to ease backporting).

…aration fixes

Followup to 12078e7. I ended up missing
a few, apparently.

Clang 16 makes -Wimplicit-function-declaration an error by default
and warns on -Wstrict-prototypes. It's free to fix -Wstrict-prototypes
while we're here and it futureproofs us, so throw that in.

The only notable part of this which might not be super obvious is
<stddef.h> for size_t.

See: 12078e7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! Sorry for the delay.

kumaraditya303 changed the title ~~gh-99086: Further -Wstrict-prototypes, -Wimplicit-function-declaratio…~~ gh-99086: Fix -Wstrict-prototypes, -Wimplicit-function-declaration warnings in configure.ac

Nov 26, 2022

Thanks @thesamesam for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

Sorry, @thesamesam and @kumaraditya303, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e35ca417fe81a64985c2b29e863ce418ae75b96e 3.11

Sorry @thesamesam and @kumaraditya303, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker e35ca417fe81a64985c2b29e863ce418ae75b96e 3.10

thesamesam added a commit to thesamesam/cpython that referenced this pull request

Dec 1, 2022

thesamesam added a commit to thesamesam/cpython that referenced this pull request

Dec 1, 2022

…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7.
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>

thesamesam added a commit to thesamesam/cpython that referenced this pull request

Dec 1, 2022

…eclaration warnings in configure.ac (pythonGH-99406)

Follow up to 12078e7..
(cherry picked from commit e35ca41)

Co-authored-by: Sam James <sam@gentoo.org>