◐ Shell
clean mode source ↗

GH-81057: remove static state from suggestions.c by kumaraditya303 · Pull Request #99411 · python/cpython

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented

Nov 12, 2022

edited by bedevere-bot

Loading

Copy link Copy Markdown

Contributor

@pablogsal pablogsal left a comment

Copy link Copy Markdown

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for the delay @kumaraditya303. Unfortunately I am dealing with a health issue and I am less available these weeks :(

kumaraditya303 reacted with thumbs up emoji

@kumaraditya303

Copy link Copy Markdown

Contributor Author

Unfortunately I am dealing with a health issue and I am less available these weeks :(

No worries, health is more important than this :)

@kumaraditya303 kumaraditya303 merged commit fe17d35 into python:main

Nov 30, 2022

@kumaraditya303 kumaraditya303 deleted the suggestions branch

November 30, 2022 11:25

carljm added a commit to carljm/cpython that referenced this pull request

Dec 1, 2022
* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments

@sweeneyde sweeneyde sweeneyde left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kumaraditya303 @corona10 @pablogsal @sweeneyde @bedevere-bot